Skip to content

Add Notation to TestAlluxioEngine_getInitUserDir in pkg\ddc\alluxio\u…#4662

Closed
You1mr wants to merge 1 commit intofluid-cloudnative:masterfrom
You1mr:ForLab1
Closed

Add Notation to TestAlluxioEngine_getInitUserDir in pkg\ddc\alluxio\u…#4662
You1mr wants to merge 1 commit intofluid-cloudnative:masterfrom
You1mr:ForLab1

Conversation

@You1mr
Copy link
Copy Markdown

@You1mr You1mr commented Mar 14, 2025

…tils_test.go

Ⅰ. Describe what this PR does

This PR adds detailed English comments to the TestAlluxioEngine_getInitUserDir method to improve readability and maintainability of the test code.

Fixes #4661

Ⅱ. Does this pull request fix one issue?

fixes #4661

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Add Notation to TestAlluxioEngine_getInitUserDir in pkg\ddc\alluxio\u…
3a48de6 
…tils_test.go

Signed-off-by: js <hmx@njujs.myguest.virtualbox.org>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 14, 2025

Hi @You1mr. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@You1mr
Copy link
Copy Markdown
Author

You1mr commented Mar 14, 2025

/cc @yangyuliufeng

@fluid-e2e-bot fluid-e2e-bot Bot requested a review from yangyuliufeng March 14, 2025 09:42
@You1mr
Copy link
Copy Markdown
Author

You1mr commented Mar 14, 2025

/assign @yangyuliufeng

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Mar 20, 2025

Please run gofmt -w pkg/ddc/alluxio/utils_test.go before updating your change. And If possible, please don't add comments inside the method. thanks.

cheyang
cheyang requested changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@You1mr Please run gofmt -w pkg/ddc/alluxio/utils_test.go before updating your change. And If possible, please don't add comments inside the method. thanks.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yangyuliufeng by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang requested changes

@yangyuliufeng yangyuliufeng Awaiting requested review from yangyuliufeng

Assignees

@yangyuliufeng yangyuliufeng

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Notation to TestAlluxioEngine_getInitUserDir in pkg\ddc\alluxio\utils_test.go

4 participants

@You1mr @cheyang @TrafalgarZZZ @yangyuliufeng